Skip to content

fix: unused delimiter settings#4807

Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso:fix-unused-delimiter-settings
May 20, 2025
Merged

fix: unused delimiter settings#4807
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso:fix-unused-delimiter-settings

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented May 20, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #4778

Proposed Changes

How do you like to solve the issue and why?

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso requested a review from a team as a code owner May 20, 2025 07:35
@gusfcarvalho
Copy link
Copy Markdown
Member

I can’t quite understand how tests passed for this feature 🤔

thanks for fixing it

@sonarqubecloud
Copy link
Copy Markdown

@Skarlso Skarlso merged commit af8c214 into external-secrets:main May 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template custom delimiters ignored

2 participants