-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Template custom delimiters ignored #4778
Description
Describe the bug
With this PR: #4558, custom delimiters have been introduced to external secrets.
Unfortunately, setting those as extra args to the external secrets container, will do nothing when executing the templates.
I have set:
--template-left-delimiter="[["
--template-right-delimiter="]]"
These flags have been ignored, and external secrets still used "{{" and "}}" as delimiters.
In the execute function i see: 'Delims("{{", "}}").', which at first look seems that even if the flags are passed to external secrets, the delimiters are still hardcoded.
To Reproduce
Steps to reproduce the behavior:
- Set non standard delimiters through flags "--template-left-delimiter" and "--template-right-delimiter"
- Create any ExternalSecret with a template using the custom delimiters
- Check the generated secret did not render the key value correctly, and the output contains the literal strings set for non standard delimiters
Expected behavior
Expected that the custom delimiters to be used for rendering templates, instead of the default ones.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
External Secrets version: v0.16.0