ENH: Icon links, latest PST, more source providers, and bug fixes#691
Merged
choldgraf merged 11 commits intoexecutablebooks:masterfrom Feb 27, 2023
Merged
ENH: Icon links, latest PST, more source providers, and bug fixes#691choldgraf merged 11 commits intoexecutablebooks:masterfrom
choldgraf merged 11 commits intoexecutablebooks:masterfrom
Conversation
Member
thanks @choldgraf. Once a new |
choldgraf
commented
Feb 26, 2023
choldgraf
commented
Feb 26, 2023
Member
Author
|
OK this one now cleans up a bunch of different things, if we can get the tests passing, I'll merge so that we can cut a new release candidate since a lot of feedback was addressed and a couple new things were added. |
Member
Author
|
cc @mmcky - making a new release candidate now so try it out! :-) https://github.com/executablebooks/sphinx-book-theme/releases/tag/v1.0.0rc3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in the latest pydata theme, and along the way includes support for their
icon-linksbuttons in our primary sidebar. We just inherit the component template and have some lightweight styling to make it look in-line with our documentation style.builder.theme_optionsthat @mmcky reportedAlso adds support for more source button providers via the pydata theme: