Skip to content

Launch button drop-down can show up even when no links are available  #694

@choldgraf

Description

@choldgraf

Our check for whether to include launch buttons just checks whether any launch button config is present. However this means somebody can specify some config, but none that result in valid launch buttons, and this will result in an empty drop-down.

This is relevant because jupyter book sets some default config, and so launch_buttons will always be present.

We should improve the check so that launch buttons only show if a valid button link can be created.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions