Skip to content

chore: cherry-pick fbfb27470bf6 from chromium#50436

Merged
VerteDinde merged 4 commits into39-x-yfrom
cherry-pick/39-x-y/chromium/fbfb27470bf6
Mar 24, 2026
Merged

chore: cherry-pick fbfb27470bf6 from chromium#50436
VerteDinde merged 4 commits into39-x-yfrom
cherry-pick/39-x-y/chromium/fbfb27470bf6

Conversation

@VerteDinde
Copy link
Copy Markdown
Member

Validate uniform block count limits at compile time on IMG.

Normally these limits are validated at link time but the IMG compiler
has issues when these limits are exceeded. Validate at compile time
instead.

Bug: chromium:475877320
Change-Id: Ieeed6914b8cdd2b5e50242d06facae62badddefd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7568129
Auto-Submit: Geoff Lang geofflang@chromium.org
Reviewed-by: Kyle Charbonneau kylechar@chromium.org
Commit-Queue: Kyle Charbonneau kylechar@chromium.org
Cr-Commit-Position: refs/heads/main@{#1586673}

Notes: Backported fix for chromium:475877320.

@VerteDinde VerteDinde requested a review from a team as a code owner March 23, 2026 22:20
@VerteDinde VerteDinde added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 39-x-y labels Mar 23, 2026
@VerteDinde VerteDinde force-pushed the cherry-pick/39-x-y/chromium/fbfb27470bf6 branch from eb2ec43 to 6084ae8 Compare March 24, 2026 01:31
VerteDinde and others added 3 commits March 24, 2026 11:17
… patch

The angle cherry-pick added MaxGeometryUniformBlocks in new locations,
but it already existed in the EXT_geometry_shader section, causing a
duplicate struct member build error in ShaderLang.h.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@VerteDinde VerteDinde force-pushed the cherry-pick/39-x-y/chromium/fbfb27470bf6 branch from 7e2028d to d0ec4c9 Compare March 24, 2026 18:18
@VerteDinde VerteDinde enabled auto-merge (squash) March 24, 2026 23:17
@VerteDinde VerteDinde merged commit 2c8b6ee into 39-x-y Mar 24, 2026
30 of 45 checks passed
@VerteDinde VerteDinde deleted the cherry-pick/39-x-y/chromium/fbfb27470bf6 branch March 24, 2026 23:22
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Mar 24, 2026

Release Notes Persisted

Backported fix for chromium:475877320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

39-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants