Skip to content

fix: prevent traffic light buttons flashing on deminiaturize#50208

Merged
jkleinsc merged 2 commits into39-x-yfrom
trop/39-x-y-bp-fix-prevent-traffic-light-buttons-flashing-on-deminiaturize-1773248581630
Mar 11, 2026
Merged

fix: prevent traffic light buttons flashing on deminiaturize#50208
jkleinsc merged 2 commits into39-x-yfrom
trop/39-x-y-bp-fix-prevent-traffic-light-buttons-flashing-on-deminiaturize-1773248581630

Conversation

@trop
Copy link
Copy Markdown
Contributor

@trop trop bot commented Mar 11, 2026

Backport of #50183

See that PR for details.

Notes: Fixed an issue where traffic light buttons would flash at position (0,0) when restoring a window with a custom trafficLightPosition from minimization on macOS.

trop bot and others added 2 commits March 11, 2026 17:03
When a window with a custom `trafficLightPosition` is minimized and
restored, macOS re-layouts the title bar container during the
deminiaturize animation, causing the traffic light buttons to briefly
appear at their default position before being repositioned.

Fix this by hiding the buttons container in `windowWillMiniaturize` and
restoring them (with a redraw to the correct position) in
`windowDidDeminiaturize`.

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested review from a team and codebytere March 11, 2026 17:03
@trop trop bot added 39-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 11, 2026
@jkleinsc jkleinsc merged commit da140ae into 39-x-y Mar 11, 2026
67 checks passed
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Mar 11, 2026

Release Notes Persisted

Fixed an issue where traffic light buttons would flash at position (0,0) when restoring a window with a custom trafficLightPosition from minimization on macOS.

@jkleinsc jkleinsc deleted the trop/39-x-y-bp-fix-prevent-traffic-light-buttons-flashing-on-deminiaturize-1773248581630 branch March 11, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

39-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant