fix: prevent traffic light buttons flashing on deminiaturize#50183
Merged
fix: prevent traffic light buttons flashing on deminiaturize#50183
Conversation
Member
|
Mark as "Fixes #50099"? |
ckerr
approved these changes
Mar 10, 2026
deepak1556
reviewed
Mar 11, 2026
Member
deepak1556
left a comment
There was a problem hiding this comment.
LGTM, just a comment about reusing the new functions.
When a window with a custom `trafficLightPosition` is minimized and restored, macOS re-layouts the title bar container during the deminiaturize animation, causing the traffic light buttons to briefly appear at their default position before being repositioned. Fix this by hiding the buttons container in `windowWillMiniaturize` and restoring them (with a redraw to the correct position) in `windowDidDeminiaturize`.
40de5b9 to
a4f83f6
Compare
deepak1556
approved these changes
Mar 11, 2026
jkleinsc
approved these changes
Mar 11, 2026
|
Release Notes Persisted
|
This was referenced Mar 11, 2026
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50207 |
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #50208 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50209 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #50099
When a window with a custom
trafficLightPositionis minimized and restored, macOS re-layouts the title bar container during the deminiaturize animation, causing the traffic light buttons to briefly appear at their default position before being repositioned.Fix this by hiding the buttons container in
windowWillMiniaturizeand restoring them (with a redraw to the correct position) inwindowDidDeminiaturize.Tested with https://gist.github.com/rubywwwilde/031350b7c4d91f5afc0e2cff51bb6173
Fixes #50099
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where traffic light buttons would flash at position (0,0) when restoring a window with a custom
trafficLightPositionfrom minimization on macOS.