fix: menu bar hiding on two setFullscreen(false)#49994
Merged
codebytere merged 2 commits into40-x-yfrom Mar 2, 2026
Merged
Conversation
`setFullscreen(false)` should do nothing when not already in fullscreen, but it hides the menu bar on Linux. Co-authored-by: WofWca <wofwca@protonmail.com>
This fixes the following bug on Linux (and maybe macOS): 1. Create a window with a menu bar. 2. Call `win.setFullScreen(false)`. The menu bar will hide. See the original bug in our project: deltachat/deltachat-desktop#4752. Co-authored-by: WofWca <wofwca@protonmail.com>
5 tasks
codebytere
approved these changes
Mar 2, 2026
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #45930
See that PR for details.
Notes: Fixed menu bar hiding after a call to
win.setFullScreen(false)when not in fullscreen on Linux.