fix: menu bar hiding on two `setFullscreen(false)` by WofWca · Pull Request #45930 · electron/electron

WofWca · 2025-03-08T16:33:02Z

Description of Change

This fixes the following bug on Linux (and maybe macOS):

Create a window with a menu bar.
Call win.setFullScreen(false).

The menu bar will hide.

2025-03-08-L0hopNZIVy.mp4

See the original bug in our project: deltachat/deltachat-desktop#4752.

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
~~[ ] relevant API documentation, tutorials, and examples are updated and follow the documentation style guide~~
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Please check if bool leaving_fullscreen = IsFullscreen() && !fullscreen; makes sense on all platforms. Frankly, I don't know what I'm doing, so perhaps take this MR as a hand-wavy suggestion

Release Notes

Notes: Fixed menu bar hiding after a call to win.setFullScreen(false) when not in fullscreen on Linux.

welcome · 2025-03-08T16:33:04Z

💖 Thanks for opening this pull request! 💖

Semantic PR titles

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

fix: don't overwrite prevent_default if default wasn't prevented
feat: add app.isPackaged() method
docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

Follow the JavaScript, C++, and Python coding style.
Run npm run lint locally to catch formatting errors earlier.
Document any user-facing changes you've made following the documentation styleguide.
Include tests when adding/changing behavior.
Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

ckerr · 2025-10-31T17:41:20Z

spec/api-browser-window-spec.ts

      it('correctly remembers state prior to fullscreen change', async () => {
        const w = new BrowserWindow({ show: false });
+
+        // This should do nothing.


(nit) this comment and the ones below are clear from the context in this PR, but if I came across it cold when reading the .ts file I would find it a little confusing.

A little wordier, but maybe // This should be a no-op since this is already the window's current state

Sounds good to me.

Suggested change

// This should do nothing.

// This should be a no-op since this is already the window's current state

Edit: whoops, there is more such comments.

shell/browser/native_window_views.cc

WofWca · 2025-10-31T17:56:58Z

So, @ckerr , do you think that this is the right approach? Have you considered whether this can break stuff? Because as I said, I have no idea what I'm doing.

If the comments is the only remaining issue, I'll come back to this in a few days

ckerr · 2025-10-31T18:19:27Z

So, @ckerr , do you think that this is the right approach? Have you considered whether this can break stuff? Because as I said, I have no idea what I'm doing.

@codebytere is the primary on this code, so I'll defer to her on this question?

shell/browser/native_window_views.cc

ckerr · 2025-11-25T15:29:00Z

@WofWca could you rebase this on top of main to try & make CI happy?

@jkleinsc does 48d1c64 address your change request?

WofWca · 2026-01-27T08:21:41Z

Hey, sorry for the delay. I rebased onto main. But I don't see anything in the previous CI run that points to a problem with my MR itself.

jkleinsc · 2026-01-30T20:21:34Z

@WofWca looks like there is code formatting issue found by our lint job that needs to be addressed:
https://github.com/electron/electron/actions/runs/21389703724/job/61665195055?pr=45930.

jkleinsc · 2026-02-18T21:25:49Z

@WofWca we require signed commits: https://www.electronjs.org/docs/latest/development/pull-requests#commit-signing. Can you sign your commits?

jkleinsc · 2026-02-26T20:46:48Z

@WofWca can you rebase with the latest from main? That should fix the lint job failing.

jkleinsc · 2026-02-27T20:05:03Z

@WofWca it looks like one of your commits is not signed: faf0b70. Can you sign this commit?

`setFullscreen(false)` should do nothing when not already in fullscreen, but it hides the menu bar on Linux.

This fixes the following bug on Linux (and maybe macOS): 1. Create a window with a menu bar. 2. Call `win.setFullScreen(false)`. The menu bar will hide. See the original bug in our project: deltachat/deltachat-desktop#4752.

WofWca · 2026-02-28T07:59:19Z

Ugh. What a mess. I have signed both of the commits now.

welcome · 2026-03-02T09:01:33Z

Congrats on merging your first pull request! 🎉🎉🎉

release-clerk · 2026-03-02T09:01:33Z

Release Notes Persisted

Fixed menu bar hiding after a call to win.setFullScreen(false) when not in fullscreen on Linux.

trop · 2026-03-02T09:02:07Z

I have automatically backported this PR to "40-x-y", please check out #49994

trop · 2026-03-02T09:02:16Z

I have automatically backported this PR to "39-x-y", please check out #49995

trop · 2026-03-02T09:02:19Z

I have automatically backported this PR to "41-x-y", please check out #49996

electron-cation bot added the semver/none label Mar 8, 2025

WofWca force-pushed the fix-menubar-hiding-on-setFullscreen-false branch 2 times, most recently from 1f26655 to 441610b Compare March 8, 2025 17:20

WofWca marked this pull request as ready for review March 8, 2025 17:21

WofWca changed the title ~~test: add failing test for setFullscreen(false)~~ fix: menu bar hiding on two setFullscreen(false) Mar 9, 2025

electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Mar 9, 2025

codebytere self-requested a review March 13, 2025 09:03

WofWca mentioned this pull request Jul 20, 2025

option to disable/enable the menu bar (maybe disable by default) deltachat/deltachat-desktop#5308

Open

ckerr approved these changes Oct 31, 2025

View reviewed changes

ckerr self-requested a review October 31, 2025 18:19

jkleinsc requested changes Nov 12, 2025

View reviewed changes

shell/browser/native_window_views.cc Show resolved Hide resolved

WofWca force-pushed the fix-menubar-hiding-on-setFullscreen-false branch from 441610b to 48d1c64 Compare November 13, 2025 07:04

WofWca force-pushed the fix-menubar-hiding-on-setFullscreen-false branch from 48d1c64 to 926d1c8 Compare January 27, 2026 08:18

WofWca force-pushed the fix-menubar-hiding-on-setFullscreen-false branch from 926d1c8 to afa3c0f Compare January 31, 2026 07:14

jkleinsc approved these changes Feb 17, 2026

View reviewed changes

codebytere approved these changes Feb 18, 2026

View reviewed changes

codebytere added semver/patch backwards-compatible bug fixes target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. and removed semver/none labels Feb 19, 2026

WofWca force-pushed the fix-menubar-hiding-on-setFullscreen-false branch from afa3c0f to 9aaf4cb Compare February 20, 2026 08:33

WofWca force-pushed the fix-menubar-hiding-on-setFullscreen-false branch from 9aaf4cb to b344e80 Compare February 27, 2026 06:33

WofWca added 2 commits February 28, 2026 11:58

test: add failing test for setFullscreen(false)

86ca9d0

`setFullscreen(false)` should do nothing when not already in fullscreen, but it hides the menu bar on Linux.

fix: menu bar hiding on two setFullScreen(false)

e7d614c

This fixes the following bug on Linux (and maybe macOS): 1. Create a window with a menu bar. 2. Call `win.setFullScreen(false)`. The menu bar will hide. See the original bug in our project: deltachat/deltachat-desktop#4752.

WofWca force-pushed the fix-menubar-hiding-on-setFullscreen-false branch from b344e80 to e7d614c Compare February 28, 2026 07:58

codebytere merged commit 20dfc93 into electron:main Mar 2, 2026
62 checks passed

This was referenced Mar 2, 2026

fix: menu bar hiding on two setFullscreen(false) #49994

Merged

fix: menu bar hiding on two setFullscreen(false) #49995

Merged

fix: menu bar hiding on two setFullscreen(false) #49996

Merged

trop bot added in-flight/40-x-y and removed target/40-x-y PR should also be added to the "40-x-y" branch. labels Mar 2, 2026

	// This should do nothing.
	// This should be a no-op since this is already the window's current state

Conversation

WofWca commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Checklist

Release Notes

Uh oh!

welcome bot commented Mar 8, 2025

Semantic PR titles

Commit signing

PR tips

Uh oh!

ckerr Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

WofWca Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

WofWca commented Oct 31, 2025

Uh oh!

ckerr commented Oct 31, 2025

Uh oh!

Uh oh!

ckerr commented Nov 25, 2025

Uh oh!

WofWca commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkleinsc commented Jan 30, 2026

Uh oh!

jkleinsc commented Feb 18, 2026

Uh oh!

jkleinsc commented Feb 26, 2026

Uh oh!

jkleinsc commented Feb 27, 2026

Uh oh!

WofWca commented Feb 28, 2026

Uh oh!

Uh oh!

welcome bot commented Mar 2, 2026

Uh oh!

release-clerk bot commented Mar 2, 2026

Uh oh!

trop bot commented Mar 2, 2026

Uh oh!

trop bot commented Mar 2, 2026

Uh oh!

trop bot commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

WofWca commented Mar 8, 2025 •

edited

Loading

WofWca Oct 31, 2025 •

edited

Loading

WofWca commented Jan 27, 2026 •

edited

Loading