Skip to content

docs: titleBarOverlay is defined as a BaseWindow ctor option#43459

Merged
ckerr merged 1 commit into32-x-yfrom
trop/32-x-y-bp-docs-titlebaroverlay-is-defined-as-a-basewindow-ctor-option-1724425377048
Aug 23, 2024
Merged

docs: titleBarOverlay is defined as a BaseWindow ctor option#43459
ckerr merged 1 commit into32-x-yfrom
trop/32-x-y-bp-docs-titlebaroverlay-is-defined-as-a-basewindow-ctor-option-1724425377048

Conversation

@trop
Copy link
Copy Markdown
Contributor

@trop trop bot commented Aug 23, 2024

Backport of #43430

See that PR for details.

Notes: Fixed an issue where titleBarOverlay was incorrectly defined on BrowserWindow and not BaseWindow.

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested review from a team and codebytere August 23, 2024 15:03
@trop trop bot added 32-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 23, 2024
@ckerr ckerr merged commit d5bf7f7 into 32-x-y Aug 23, 2024
@ckerr ckerr deleted the trop/32-x-y-bp-docs-titlebaroverlay-is-defined-as-a-basewindow-ctor-option-1724425377048 branch August 23, 2024 15:38
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Aug 23, 2024

Release Notes Persisted

Fixed an issue where titleBarOverlay was incorrectly defined on BrowserWindow and not BaseWindow.

Copy link
Copy Markdown

@MpcOS77 MpcOS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

32-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants