Skip to content

docs: titleBarOverlay is defined as a BaseWindow ctor option#43430

Merged
jkleinsc merged 1 commit intomainfrom
titlebaroverlay-is-base-window
Aug 23, 2024
Merged

docs: titleBarOverlay is defined as a BaseWindow ctor option#43430
jkleinsc merged 1 commit intomainfrom
titlebaroverlay-is-base-window

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Aug 22, 2024

Description of Change

Closes #43399.

Fixes an issue where titleBarOverlay was incorrectly defined on BrowserWindow and not BaseWindow.

Checklist

Release Notes

Notes: Fixed an issue where titleBarOverlay was incorrectly defined on BrowserWindow and not BaseWindow.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/31-x-y PR should also be added to the "31-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch. target/33-x-y PR should also be added to the "33-x-y" branch. labels Aug 22, 2024
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Aug 22, 2024
ckerr
ckerr approved these changes Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @electron/wg-api just as a heads-up, but not flagging 'em as a reviewer since this is a bugfix rather than an API change in practice

@jkleinsc jkleinsc merged commit 3a5a1ea into main Aug 23, 2024
@jkleinsc jkleinsc deleted the titlebaroverlay-is-base-window branch August 23, 2024 15:02
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Aug 23, 2024

Release Notes Persisted

Fixed an issue where titleBarOverlay was incorrectly defined on BrowserWindow and not BaseWindow.

This was referenced Aug 23, 2024
Merged
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Aug 23, 2024

I have automatically backported this PR to "31-x-y", please check out #43458

@trop trop bot added in-flight/31-x-y and removed target/31-x-y PR should also be added to the "31-x-y" branch. labels Aug 23, 2024
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Aug 23, 2024

I have automatically backported this PR to "32-x-y", please check out #43459

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Aug 23, 2024

I have automatically backported this PR to "33-x-y", please check out #43460

@trop trop bot added in-flight/32-x-y in-flight/33-x-y merged/33-x-y PR was merged to the "33-x-y" branch. merged/32-x-y PR was merged to the "32-x-y" branch. and removed target/32-x-y PR should also be added to the "32-x-y" branch. target/33-x-y PR should also be added to the "33-x-y" branch. in-flight/33-x-y labels Aug 23, 2024
@trop trop bot added merged/31-x-y PR was merged to the "31-x-y" branch. and removed in-flight/32-x-y in-flight/31-x-y labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@miniak miniak Awaiting requested review from miniak

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees

No one assigned

Labels

merged/31-x-y PR was merged to the "31-x-y" branch. merged/32-x-y PR was merged to the "32-x-y" branch. merged/33-x-y PR was merged to the "33-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing titleBarOverlay in BaseWindowConstructorOption type

3 participants

@codebytere @ckerr @jkleinsc