Skip to content

refactor: remove dead named-window lookup from guest-window-manager#50497

Merged
jkleinsc merged 1 commit into41-x-yfrom
trop/41-x-y-bp-refactor-remove-dead-named-window-lookup-from-guest-window-manager-1774460936437
Mar 26, 2026
Merged

refactor: remove dead named-window lookup from guest-window-manager#50497
jkleinsc merged 1 commit into41-x-yfrom
trop/41-x-y-bp-refactor-remove-dead-named-window-lookup-from-guest-window-manager-1774460936437

Conversation

@trop
Copy link
Copy Markdown
Contributor

@trop trop bot commented Mar 25, 2026

Backport of #50474

See that PR for details.

Notes: none

The frameNamesToWindow map was a holdover from the BrowserWindowProxy
IPC shim. Since nativeWindowOpen became the only code path, Blink's
FrameTree::FindOrCreateFrameForNavigation resolves named window targets
directly in the renderer, scoped to the opener's browsing context
group. When a matching named window exists, Blink navigates it without
ever sending a CreateNewWindow IPC to the browser, so this map was
never consulted in the legitimate same-opener case.

The only time the map found a match was when two unrelated renderers
happened to use the same target name, in which case openGuestWindow
would short-circuit before consuming the guest WebContents that
Chromium had already created for the new window, leaking it.

Adds a test verifying Blink handles same-opener named-target reuse
end-to-end without any browser-side tracking.

Co-authored-by: Sam Attard <sattard@anthropic.com>
@trop trop bot requested review from a team and MarshallOfSound March 25, 2026 17:49
@trop trop bot added 41-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 25, 2026
@jkleinsc jkleinsc merged commit 880b1e0 into 41-x-y Mar 26, 2026
158 of 161 checks passed
@jkleinsc jkleinsc deleted the trop/41-x-y-bp-refactor-remove-dead-named-window-lookup-from-guest-window-manager-1774460936437 branch March 26, 2026 15:46
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Mar 26, 2026

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

41-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants