refactor: remove dead named-window lookup from guest-window-manager#50474
Merged
MarshallOfSound merged 1 commit intomainfrom Mar 25, 2026
Merged
refactor: remove dead named-window lookup from guest-window-manager#50474MarshallOfSound merged 1 commit intomainfrom
MarshallOfSound merged 1 commit intomainfrom
Conversation
The frameNamesToWindow map was a holdover from the BrowserWindowProxy IPC shim. Since nativeWindowOpen became the only code path, Blink's FrameTree::FindOrCreateFrameForNavigation resolves named window targets directly in the renderer, scoped to the opener's browsing context group. When a matching named window exists, Blink navigates it without ever sending a CreateNewWindow IPC to the browser, so this map was never consulted in the legitimate same-opener case. The only time the map found a match was when two unrelated renderers happened to use the same target name, in which case openGuestWindow would short-circuit before consuming the guest WebContents that Chromium had already created for the new window, leaking it. Adds a test verifying Blink handles same-opener named-target reuse end-to-end without any browser-side tracking.
codebytere
approved these changes
Mar 25, 2026
|
No Release Notes |
This was referenced Mar 25, 2026
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50495 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50496 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50497 |
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #50498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
frameNamesToWindowmap was a holdover from the BrowserWindowProxy IPC shim. SincenativeWindowOpenbecame the only code path in #29405, Blink'sFrameTree::FindOrCreateFrameForNavigationresolves named window targets directly in the renderer, scoped to the opener's browsing context group. When a matching named window exists, Blink navigates it without ever sending aCreateNewWindowIPC to the browser — so this JS-side map was never consulted in the legitimate same-opener case.The only time the map found a match was when two unrelated renderers happened to use the same target name, in which case
openGuestWindowwould short-circuit before consuming theguestWebContents that Chromium had already created for the new window, leaking it.Adds a test verifying Blink handles same-opener named-target reuse end-to-end (same
WindowProxyreturned, existing child navigated,setWindowOpenHandlernot re-invoked) without any browser-side tracking.Notes: none