internal/stack: improve semverLessThan error handling#2101
Merged
jsoriano merged 1 commit intoelastic:mainfrom Sep 18, 2024
Merged
internal/stack: improve semverLessThan error handling#2101jsoriano merged 1 commit intoelastic:mainfrom
jsoriano merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
💚 Build Succeeded
|
jsoriano
approved these changes
Sep 16, 2024
Member
jsoriano
left a comment
There was a problem hiding this comment.
LGTM, I only wonder if we should be a bit more verbose here.
Contributor
Author
|
@jsoriano Would you mind merging this? I cannot. |
Contributor
|
@efd6 That error should also be fixed in integrations via this PR elastic/integrations#11126 |
Contributor
Author
|
@mrodm Thanks. Trying now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes errors like this actionable.
ref elastic/integrations#11052