[CI] Fix script that retrieves oldest supported version#11126
Merged
mrodm merged 4 commits intoelastic:mainfrom Sep 16, 2024
Merged
[CI] Fix script that retrieves oldest supported version#11126mrodm merged 4 commits intoelastic:mainfrom
mrodm merged 4 commits intoelastic:mainfrom
Conversation
🚀 Benchmarks reportTo see the full report comment with |
Major and minor numbers from versions were compared as strings, but they should be compared as integers.
jlind23
approved these changes
Sep 13, 2024
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @mrodm |
|
jsoriano
approved these changes
Sep 16, 2024
mrodm
added a commit
to mrodm/integrations
that referenced
this pull request
Sep 17, 2024
Fix find oldest supported version script. Major and minor numbers from versions were compared as strings, but they should be compared as integers.
2 tasks
This was referenced Sep 18, 2024
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
Fix find oldest supported version script. Major and minor numbers from versions were compared as strings, but they should be compared as integers.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
Fix find oldest supported version script. Major and minor numbers from versions were compared as strings, but they should be compared as integers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fix script in charge of retrieving the oldest supported version of the stack to use for
elastic-package stack up -v -d --version <version>command.Without the fix there were packages that the stack version assigned was
8.x-SNAPSHOT, but the script should return the version in the manifest since it is older than the ones available in the artifacts-api response:Example:
Example of artifacts-api response:
{ "versions": [ "7.17.19", "7.17.20", "7.17.21", "7.17.22", "7.17.23", "7.17.24-SNAPSHOT", "7.17.24", "7.17.25-SNAPSHOT", "7.17.25", "8.12.3", "8.13.0+build202403222138", "8.13.0+build202403281537", "8.13.0+build202403281758", "8.13.0", "8.13.1+build202404121909", "8.13.1+build202404122010", "8.13.1", "8.13.2", "8.13.3", "8.13.4", "8.13.5", "8.14.0", "8.14.1", "8.14.2", "8.14.3", "8.14.4", "8.15.0", "8.15.1-SNAPSHOT", "8.15.1", "8.15.2-SNAPSHOT", "8.15.2", "8.16.0-SNAPSHOT", "9.0.0-SNAPSHOT" ], "aliases": [ "7.17-SNAPSHOT", "7.17", "8.x-SNAPSHOT", "8.12", "8.13", "8.14", "8.15-SNAPSHOT", "8.15", "8.16-SNAPSHOT", "9.0-SNAPSHOT" ], "manifests": { "last-update-time": "Fri, 13 Sep 2024 11:36:29 UTC", "seconds-since-last-update": 139 } }Additional changes:
Update context parameter used in
buildkite-agent annotatecommand. It must be--context.Example build failing:
https://buildkite.com/elastic/integrations/builds/15884