[release/8.0.3xx] Add Dev Device ID#43360
Merged
marcpopMSFT merged 4 commits intorelease/8.0.3xxfrom Oct 10, 2024
Merged
Conversation
…hing fails but don't error our code refactor the caching code slightly for simplicity
marcpopMSFT
approved these changes
Oct 4, 2024
pieandcakes
approved these changes
Oct 9, 2024
pieandcakes
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #43148 to release/8.0.3xx
Summary
DevDeviceID was introduced in RC2 as a way to be consistent with Visual Studio on how to track individual devices. This change is to backport the device ID to 8.0 which will be in support for another 2 years. This change includes the original backport as well as the RC2 Fix #43471
Customer Impact
.NET 8 SDKs would have to continue to rely on the MacAddress to compare data with VS which would force using different queries for 9 versus 8.
Regression
No.
Testing
Automated
Risk
Low