Merged
Conversation
Make sure we return an empty string if caching fails but don't error our code refactor the caching code slightly for simplicity
baronfel
approved these changes
Sep 4, 2024
Member
|
The important points that I checked were:
All of that seems aligned with the spec. |
Member
Author
|
Failure is the known template engine failure |
pieandcakes
approved these changes
Sep 4, 2024
pieandcakes
left a comment
There was a problem hiding this comment.
Reviewed location and implementation based on spec.
Looks correct
Member
|
Added the documentation label so we don't drop this during the final documentation push. |
Member
Author
|
/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/backport to release/8.0.1xx |
Contributor
|
Started backporting to release/8.0.1xx: https://github.com/dotnet/sdk/actions/runs/10816238261 |
Member
Author
|
/backport to release/8.0.3xx |
Contributor
|
Started backporting to release/8.0.3xx: https://github.com/dotnet/sdk/actions/runs/10818712032 |
Member
Author
|
/backport to release/8.0.4xx |
Contributor
|
Started backporting to release/8.0.4xx: https://github.com/dotnet/sdk/actions/runs/10819303900 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42804
I followed the spec for where we should cache the ID from. I confirmed that it was getting populated with a guid in the telemetry common properties and on windows was saved in the cache. This is all assuming I got the locations correct. Ping me offline for the spec and I can link it for review.