[release/9.0] Arm64: Use TYP_SIMD8 for AddAcross #108805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
|
@dotnet/jit-contrib @tannergooding |
jeffschwMSFT
approved these changes
Oct 11, 2024
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. please get a code review. we will take for consideration in 9 GA
Contributor
|
The failure seems to be known failure
not sure why |
Member
|
please get a code review and then we can merge |
tannergooding
approved these changes
Oct 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108727 to release/9.0
/cc @kunalspathak
Customer Impact
When creating
AddAcross()we were wrongly setting the wrong return type toTYP_SIMD16instead ofTYP_SIMD8. When customer useAdvSimd.Arm64.AddAcross()directly or indirectly when usingVector128.Sum()(which we translate intoAddAcross()as part of #97460). The effect might be visible when during code generation, we would wrongly produce a value in v128 register instead of v64 and take dependence on data present in upper-half of v128 because of that, which can be garbage, leading to silent codegen issues.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Verified locally and added test cases
Risk
Low: This affects
AddAcross()intrinsic Arm64.IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.