Arm64: Use TYP_SIMD8 for AddAcross #108727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dotnet/jit-contrib |
Member
|
Are we going to backport this to 9? |
Contributor
Author
yes |
3 tasks
Contributor
Author
|
ping @dotnet/jit-contrib @AndyAyersMS |
This was referenced Oct 11, 2024
Open
AndyAyersMS
reviewed
Oct 11, 2024
Member
AndyAyersMS
left a comment
There was a problem hiding this comment.
Jit changes LGTM.
You need to fix the test case.
tannergooding
approved these changes
Oct 11, 2024
Contributor
Author
|
The failure doesn't repro for me when downloaded the helix payload. Rerunning the tests. |
Contributor
Author
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11298729218 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddAcross always return
Vector64<T>and we should useTYP_SIMD8when trying to create the intrinsics.Fixes: #108612