Skip to content

Remove scripted npm update for yarn-based install-command#700

Merged
jaffrepaul merged 1 commit into
cypress-io:masterfrom
MikeMcC399:fix/update-script
Jan 9, 2023
Merged

Remove scripted npm update for yarn-based install-command#700
jaffrepaul merged 1 commit into
cypress-io:masterfrom
MikeMcC399:fix/update-script

Conversation

@MikeMcC399

Copy link
Copy Markdown
Collaborator

This PR resolves issue #699 "npm-install-v10-examples script targets yarn example-install-command".

It removes the incorrect instruction

cd ../install-command && npm install cypress@latest

from npm-install-v10-examples.sh.

Since examples/v10/install-command is based on yarn it must only be updated using yarn rather than npm.

Verification

Execute npm-install-v10-examples.sh locally and ensure that there is no change to the files in the directory examples/v10/install-command.

@MikeMcC399

MikeMcC399 commented Jan 1, 2023

Copy link
Copy Markdown
Collaborator Author

@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 5, 2023 18:06
@jaffrepaul jaffrepaul merged commit 37c511b into cypress-io:master Jan 9, 2023
@MikeMcC399 MikeMcC399 deleted the fix/update-script branch January 10, 2023 04:54
kodiakhq Bot referenced this pull request in weareinreach/InReach Jan 11, 2023
)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v5.0.4` -> `v5.0.5` |

---

### Release Notes

<details>
<summary>cypress-io/github-action</summary>

### [`v5.0.5`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.5)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.4...v5.0.5)

**Docs/Tooling Updates**

-   [https://github.com/cypress-io/github-action/pull/692](https://togithub.com/cypress-io/github-action/pull/692)
-   [https://github.com/cypress-io/github-action/pull/695](https://togithub.com/cypress-io/github-action/pull/695)

**Update Tests**

-   [https://github.com/cypress-io/github-action/pull/698](https://togithub.com/cypress-io/github-action/pull/698)
-   [https://github.com/cypress-io/github-action/pull/700](https://togithub.com/cypress-io/github-action/pull/700)

**Update Dependencies**

-   [https://github.com/cypress-io/github-action/pull/712](https://togithub.com/cypress-io/github-action/pull/712)
-   [https://github.com/cypress-io/github-action/pull/716](https://togithub.com/cypress-io/github-action/pull/716)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach).



PR-URL: #154
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants