Skip to content

Create yarn.lock for install-command-v10#698

Merged
jaffrepaul merged 1 commit into
cypress-io:masterfrom
MikeMcC399:fix/install-command-v10
Jan 9, 2023
Merged

Create yarn.lock for install-command-v10#698
jaffrepaul merged 1 commit into
cypress-io:masterfrom
MikeMcC399:fix/install-command-v10

Conversation

@MikeMcC399

Copy link
Copy Markdown
Collaborator

This PR resolves issue #697 "Missing yarn lock file for example-install-command on v10".

Verification

Steps to reproduce

Push to master to trigger example-install-command.yml

Search for the logs with https://github.com/cypress-io/github-action/actions/workflows/example-install-command.yml?query=branch%3Amaster and then view the job "install-command-v10" > "Custom Yarn command"

Check that the workflow executes successfully and there is no warning about lock files from yarn.

The yarn message:
"warning nohoist config is ignored in "cypress" because it is not a private package."
can be ignored. It is fixed in Cypress 10.2.0.

Note: Issue #684 suggests updating all v10 examples to use Cypress 12.x which would then cause this warning to be resolved as well.

@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

Log 6478358232 shows corrected execution using yarn.lock for v10 test.

@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

@MikeMcC399 MikeMcC399 force-pushed the fix/install-command-v10 branch from 048e9d7 to c76b75c Compare January 5, 2023 17:37
@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 5, 2023 17:45
@MikeMcC399 MikeMcC399 force-pushed the fix/install-command-v10 branch from c76b75c to 4a4528b Compare January 7, 2023 16:20
@jaffrepaul jaffrepaul merged commit e7cfd6c into cypress-io:master Jan 9, 2023
@MikeMcC399 MikeMcC399 deleted the fix/install-command-v10 branch January 9, 2023 18:40
kodiakhq Bot referenced this pull request in weareinreach/InReach Jan 11, 2023
)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v5.0.4` -> `v5.0.5` |

---

### Release Notes

<details>
<summary>cypress-io/github-action</summary>

### [`v5.0.5`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.5)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.4...v5.0.5)

**Docs/Tooling Updates**

-   [https://github.com/cypress-io/github-action/pull/692](https://togithub.com/cypress-io/github-action/pull/692)
-   [https://github.com/cypress-io/github-action/pull/695](https://togithub.com/cypress-io/github-action/pull/695)

**Update Tests**

-   [https://github.com/cypress-io/github-action/pull/698](https://togithub.com/cypress-io/github-action/pull/698)
-   [https://github.com/cypress-io/github-action/pull/700](https://togithub.com/cypress-io/github-action/pull/700)

**Update Dependencies**

-   [https://github.com/cypress-io/github-action/pull/712](https://togithub.com/cypress-io/github-action/pull/712)
-   [https://github.com/cypress-io/github-action/pull/716](https://togithub.com/cypress-io/github-action/pull/716)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach).



PR-URL: #154
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants