Specify Node.js 16.16.0 for main build-and-test#778
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Align main.yml to Node.js version defined in https://github.com/actions/runner/blob/main/src/Misc/externals.sh for JavaScript actions. closes cypress-io#718
24787ff to
f9d2511
Compare
jaffrepaul
approved these changes
Feb 10, 2023
|
🎉 This PR is included in version 5.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #718 "Multiple node test in main workflow"
The
build-and-testjob runs on Node.js 16.16.0 which corresponds to the version provided in https://github.com/actions/runner/blob/main/src/Misc/externals.sh. The additional repeat runs using Node.js 16 and 18 are removed, since they are not needed. The action itself always runs under the version defined in https://github.com/cypress-io/github-action/blob/master/action.yml. (Refer to GitHub documentationrunsfor JavaScript actions).The
releasejob is unchanged and runs under the default Node.js version for the ubuntu-22.04 runner (currently 16.19.0, migrating to 18 from Feb 13, 2023 onwards). The JavaScript action cycjimmy/semantic-release-action@v3 is configured fornode16.Verification
Push to
masterand ensure that the actionmainshows success.