Problem description
The workflow .github/workflows/main.yml builds the action, and tests Markdown links on Node.js 14, 16 & 18 in the job build-and-test.
The GHA JavaScript action runs on Node.js 16, as defined in:
Although the results of building on Node.js 14 and 18 are usually identical to building on Node.js 16, the tests on 14 and 18 are not necessary.
Testing Markdown links under each Node.js version is redundant. The Markdown links are used through GitHub, not through GHA and there is no relation to any Node.js version for a user accessing the Markdown documents.
Expected behavior
build-and-test should run under the Node.js version specified by action.yml i.e. node16, which is provided by the GitHub actions/runner through src/Misc/externals.sh. This is currently
NODE16_VERSION="16.13.0"
The Markdown link check should run only once.
Suggested fix
In .github/workflows/main.yml the job build-and-test should run under Node.js 16.13.0 only.
Problem description
The workflow .github/workflows/main.yml builds the action, and tests Markdown links on Node.js 14, 16 & 18 in the job
build-and-test.The GHA JavaScript action runs on Node.js 16, as defined in:
github-action/action.yml
Lines 90 to 91 in 37c511b
Although the results of building on Node.js 14 and 18 are usually identical to building on Node.js 16, the tests on 14 and 18 are not necessary.
Testing Markdown links under each Node.js version is redundant. The Markdown links are used through GitHub, not through GHA and there is no relation to any Node.js version for a user accessing the Markdown documents.
Expected behavior
build-and-testshould run under the Node.js version specified by action.yml i.e.node16, which is provided by the GitHub actions/runner through src/Misc/externals.sh. This is currentlyNODE16_VERSION="16.13.0"The Markdown link check should run only once.
Suggested fix
In .github/workflows/main.yml the job
build-and-testshould run under Node.js 16.13.0 only.