refactor: replace lodash.isplainobject with is-plain-obj"#4601
refactor: replace lodash.isplainobject with is-plain-obj"#4601escapedcat merged 2 commits intoconventional-changelog:masterfrom
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
There was a problem hiding this comment.
Pull request overview
Replaces the unmaintained lodash.isplainobject dependency with is-plain-obj across the affected commitlint packages.
Changes:
- Swap
lodash.isplainobjectimports tois-plain-objin@commitlint/loadand@commitlint/cz-commitlint - Update package dependencies to remove
lodash.isplainobjectand@types/lodash.isplainobject, and addis-plain-obj - Refresh
yarn.lockaccordingly (removeslodash.isplainobject/ types entries, addsis-plain-obj@^4.1.0)
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removes lodash.isplainobject and its types; adds lock entry for is-plain-obj@^4.1.0. |
| @commitlint/load/src/load.ts | Updates isPlainObject import to use is-plain-obj. |
| @commitlint/load/package.json | Replaces lodash.isplainobject dependency with is-plain-obj and removes the related @types devDependency. |
| @commitlint/cz-commitlint/src/store/prompts.ts | Updates isPlainObject import to use is-plain-obj. |
| @commitlint/cz-commitlint/package.json | Replaces lodash.isplainobject dependency with is-plain-obj and removes the related @types devDependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks! |
User description
Description
Replace
lodash.isplainobjectwithis-plain-obj. Extracted from #4596.Motivation and Context
lodashper-method packages is NOT maintained. So i replacelodash.isplainobjectwithis-plain-obj.Usage examples
Nothing.
How Has This Been Tested?
I run test in each changed packages (
@commitlint/cz-commitlint,@commitlint/load).Types of changes
Checklist:
PR Type
Enhancement
Description
Replace unmaintained
lodash.isplainobjectwithis-plain-objUpdate dependencies in
@commitlint/cz-commitlintpackageUpdate dependencies in
@commitlint/loadpackageRemove unused type definitions for lodash package
Diagram Walkthrough
File Walkthrough
prompts.ts
Update isPlainObject import source@commitlint/cz-commitlint/src/store/prompts.ts
lodash.isplainobjecttois-plain-objload.ts
Update isPlainObject import source@commitlint/load/src/load.ts
lodash.isplainobjecttois-plain-objpackage.json
Update dependencies and remove type definitions@commitlint/cz-commitlint/package.json
lodash.isplainobject^4.0.6 withis-plain-obj^4.1.0 independencies
@types/lodash.isplainobjectfrom devDependenciespackage.json
Update dependencies and remove type definitions@commitlint/load/package.json
lodash.isplainobject^4.0.6 withis-plain-obj^4.1.0 independencies
@types/lodash.isplainobjectfrom devDependencies