refactor: replace some lodash methods#4596
refactor: replace some lodash methods#4596hyperz111 wants to merge 10 commits intoconventional-changelog:masterfrom
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||
|
Some tests seem to fail in CI. Can you have a look? |
I think this is because |
I use |
|
Some test still failing :P |
|
If fabiospampinato/kasi#1 is merged, maybe the test don't fail again. |
|
Hm, alright. Not sure if these dep changes are worth the hassle currently ;) |
|
@escapedcat, can you run it again? :) |
|
Ok, the CLI test is fail. Let me check it again. |
|
Maybe the problem is array handling difference between |
|
I don't know why the test is still failling, but when i try to execute the CLI like in failed tests scenario, i get the expected output. |
|
Hm, this is a refactor that is, as much as this could benefit from smaller deps(?), not worth skipping tests. |
We have so many lodash per-method packages in our dependencies tree. So using the smaller alternative is better for faster installation. I don't want to use |
|
Maybe i should send one PR for one module replacing. Wdyt @escapedcat? If yes, i will close this and try send another PR. |
|
Yeah, let's try that |
|
Thanks btw, this reminded me that I wanted to get rid of |
Description
Replace some
lodash.*packages with some better alternatives. ExceptmergeWith.Motivation and Context
I think if some lodash methods is should be replaced with some alternative and native ways.
Usage examples
Nothing.
How Has This Been Tested?
I run test in each changed package.
Types of changes
Checklist: