refactor: replace lodash.uniq with simple code by hyperz111 · Pull Request #4600 · conventional-changelog/commitlint

hyperz111 · 2026-01-22T16:02:04Z

User description

Description

Replace lodash.uniq(array) with [...new Set(array)]. Extracted from #4596.

Motivation and Context

Now we can do [...new Set(array)] instead lodash.uniq(array).

Usage examples

Nothing

How Has This Been Tested?

I run the test in changed package (@commitlint/load).

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

PR Type

Enhancement

Description

Replace lodash.uniq dependency with native Set-based deduplication
Remove lodash.uniq package from dependencies and type definitions
Use [...new Set(array)] pattern for array deduplication

Diagram Walkthrough

flowchart LR
  A["lodash.uniq import"] -->|"remove"| B["Native Set deduplication"]
  C["lodash.uniq dependency"] -->|"remove"| D["package.json updated"]
  B -->|"use [...new Set()]"| E["load.ts implementation"]

File Walkthrough

Relevant files

Enhancement

load.ts `Replace lodash.uniq with native Set deduplication` @commitlint/load/src/load.ts Removed `lodash.uniq` import statement Replaced `uniq(extended.plugins)` call with inline `[...new` `Set(extended.plugins)]` deduplication Local variable `uniq` now holds the deduplicated array result	+2/-2

Dependencies

package.json `Remove lodash.uniq package dependencies` @commitlint/load/package.json Removed `lodash.uniq` from dependencies Removed `@types/lodash.uniq` from devDependencies Kept `lodash.merge` and `lodash.isplainobject` as they are still in use	+1/-3

qodo-code-review · 2026-01-22T16:02:28Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
🔴	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Vague variable name: The new variable name `uniq` is not self-documenting and should be renamed to something clearer like `uniquePlugins` to reflect its purpose. Referred Code const uniq = [...new Set(extended.plugins)]; for (const plugin of uniq) { Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

codesandbox-ci · 2026-01-22T16:02:42Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

qodo-code-review · 2026-01-22T16:03:12Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Iterate directly over the Set Avoid creating an unnecessary intermediate array by iterating directly over the `new Set(extended.plugins)`. @commitlint/load/src/load.ts [87-88] -const uniq = [...new Set(extended.plugins)]; -for (const plugin of uniq) { +for (const plugin of new Set(extended.plugins)) { Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly points out that creating an intermediate array is unnecessary, as a `Set` is directly iterable, leading to more concise and slightly more memory-efficient code.	Low
Update

Copilot

Pull request overview

This PR replaces the lodash.uniq dependency with native JavaScript Set-based deduplication to reduce external dependencies and use modern JavaScript features.

Changes:

Removed lodash.uniq import and replaced usage with [...new Set(array)] pattern
Removed lodash.uniq and @types/lodash.uniq from package dependencies
Updated yarn.lock to reflect dependency removal

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
@commitlint/load/src/load.ts	Replaced `lodash.uniq` function call with native Set deduplication for plugins array
@commitlint/load/package.json	Removed `lodash.uniq` from dependencies and `@types/lodash.uniq` from devDependencies
yarn.lock	Removed package entries for `lodash.uniq` and `@types/lodash.uniq`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@commitlint/load/src/load.ts

escapedcat · 2026-01-22T16:35:47Z

Please have a look at the comment from copilot, thanks!

hyperz111 · 2026-01-23T07:41:11Z

@escapedcat

escapedcat · 2026-01-23T12:02:54Z

Thanks!

chore: replace lodash.uniq with simple code

b55c1b9

qodo-code-review bot added the Review effort 2/5 label Jan 22, 2026

escapedcat requested a review from Copilot January 22, 2026 16:29

Copilot started reviewing on behalf of escapedcat January 22, 2026 16:29 View session

escapedcat changed the title ~~chore: replace lodash.uniq with simple code~~ reactor: replace lodash.uniq with simple code Jan 22, 2026

escapedcat changed the title ~~reactor: replace lodash.uniq with simple code~~ refactor: replace lodash.uniq with simple code Jan 22, 2026

Copilot AI reviewed Jan 22, 2026

View reviewed changes

@commitlint/load/src/load.ts Outdated Show resolved Hide resolved

chore: use better name

93909c2

escapedcat merged commit 2b3e68b into conventional-changelog:master Jan 23, 2026
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: replace lodash.uniq with simple code#4600

refactor: replace lodash.uniq with simple code#4600
escapedcat merged 2 commits intoconventional-changelog:masterfrom
hyperz111:lodash.uniq

hyperz111 commented Jan 22, 2026 •

edited

Loading

Uh oh!

qodo-code-review bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

qodo-code-review bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

escapedcat commented Jan 22, 2026

Uh oh!

hyperz111 commented Jan 23, 2026

Uh oh!

Uh oh!

escapedcat commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

hyperz111 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Description

Motivation and Context

Usage examples

How Has This Been Tested?

Types of changes

Checklist:

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

qodo-code-review bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Compliance Guide 🔍

Uh oh!

codesandbox-ci bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qodo-code-review bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

escapedcat commented Jan 22, 2026

Uh oh!

hyperz111 commented Jan 23, 2026

Uh oh!

Uh oh!

escapedcat commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

hyperz111 commented Jan 22, 2026 •

edited

Loading

qodo-code-review bot commented Jan 22, 2026 •

edited

Loading

codesandbox-ci bot commented Jan 22, 2026 •

edited

Loading

qodo-code-review bot commented Jan 22, 2026 •

edited

Loading