Skip to content

fix(reset): Add cycle detection fix for services that are prefixed with the name of a preceding service#704

Merged
glours merged 1 commit intocompose-spec:mainfrom
idsulik:issue-12235-2
Oct 30, 2024
Merged

fix(reset): Add cycle detection fix for services that are prefixed with the name of a preceding service#704
glours merged 1 commit intocompose-spec:mainfrom
idsulik:issue-12235-2

Conversation

@idsulik
Copy link
Copy Markdown
Contributor

@idsulik idsulik commented Oct 29, 2024

Fixed the cycle detector #703

It detects cycle for services that are prefixed with the name of a preceding service
docker/compose#12235 (comment)

…th the name of a preceding service

Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Copy link
Copy Markdown
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @idsulik for the quick fix and for adding the test 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants