Skip to content

fix(reset): Add cycle detector in reset.go#703

Merged
glours merged 2 commits intocompose-spec:mainfrom
idsulik:issue-12235
Oct 28, 2024
Merged

fix(reset): Add cycle detector in reset.go#703
glours merged 2 commits intocompose-spec:mainfrom
idsulik:issue-12235

Conversation

@idsulik
Copy link
Copy Markdown
Contributor

@idsulik idsulik commented Oct 26, 2024

Issue: docker/compose#12235
I added the cycle detector to reset.go.
Example yaml to reproduce the issue:

x-healthcheck: &healthcheck
  healthcheck:
    test: [ "CMD", "wget", "--quiet", "--spider", "--timeout=1", "http://localhost:9000/health/live" ]
    start_period: 20s
    start_interval: 1s
    interval: 30s
    timeout: 2s
    retries: 5


  egress-service:
    <<: *healthcheck

@idsulik idsulik requested a review from ndeloof as a code owner October 26, 2024 07:09
@idsulik
fix(reset): Add cycle detector in reset.go
4f48073 
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
@idsulik
fix reset.go
fae4c28 
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
glours
glours approved these changes Oct 28, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @idsulik for the fix

@glours glours merged commit 222d93c into compose-spec:main Oct 28, 2024
@idsulik idsulik mentioned this pull request Oct 29, 2024
Merged
@idsulik idsulik deleted the issue-12235 branch January 21, 2025 14:41
@GoVulnBot GoVulnBot mentioned this pull request Jan 21, 2025
Closed
This was referenced Jan 24, 2025
Merged
Merged
This was referenced Feb 5, 2025
Merged
Merged
This was referenced Feb 13, 2025
Merged
Merged
This was referenced Feb 25, 2025
Merged
Merged
Merged
Merged
This was referenced Mar 5, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Mar 18, 2025
Merged
1 task
@github-actions github-actions bot mentioned this pull request Mar 29, 2025
Merged
1 task
@github-actions github-actions bot mentioned this pull request Apr 15, 2025
Merged
1 task
@github-actions github-actions bot mentioned this pull request Apr 25, 2025
Merged
1 task
This was referenced Oct 27, 2025
Merged
Merged
Merged
This was referenced Dec 18, 2025
Merged
Merged
This was referenced Jan 15, 2026
Merged
Merged
@github-actions github-actions bot mentioned this pull request Feb 4, 2026
Merged
1 task
This was referenced Feb 13, 2026
Merged
Merged
Merged
This was referenced Feb 24, 2026
Merged
Merged
Merged
This was referenced Mar 6, 2026
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 18, 2026
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 26, 2026
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glours glours glours approved these changes

@ndeloof ndeloof Awaiting requested review from ndeloof ndeloof is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@idsulik @glours