load configuration file with right ResourceLoader#701
Merged
glours merged 2 commits intocompose-spec:mainfrom Oct 24, 2024
Merged
Conversation
7ba1cd6 to
95281eb
Compare
ndeloof
approved these changes
Oct 22, 2024
Collaborator
ndeloof
left a comment
There was a problem hiding this comment.
LGTM, some minor comment
|
|
||
| for i, p := range configFiles { | ||
| for _, loader := range opts.ResourceLoaders { | ||
| _, isLocalResourceLoader := loader.(localResourceLoader) |
Collaborator
There was a problem hiding this comment.
if local loader reject Accept it's highly probable it will also fail on Load, so why not just let it reject path and get this function return an error if no loader accepted the path ?
Collaborator
Author
There was a problem hiding this comment.
Yes but you won't have the reason why.
What I could do is changing the Accept signature to return an error in addition of the boolean, WDYT?
Collaborator
There was a problem hiding this comment.
the other option could be for localResource Loader to always accept path. The Load can return file not found error
Collaborator
Author
There was a problem hiding this comment.
Ok I'll adapt the Accept function of resource loader
aebbee9 to
b5c8e72
Compare
ndeloof
approved these changes
Oct 23, 2024
a41bb55 to
0f71bc7
Compare
Signed-off-by: Matthew Humphreys <ge65yay@tum.de>
and pass workdir to LoadConfigFiles func to setup ConfigDetails Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
0f71bc7 to
e16daf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect and use the right ResourceLoader to load a config file and add it
ConfigDetailsstruct.LocalResourceLoaderis always used as the last loader and should failed if it's not able to parse the configuration file.This PR replace #592