Use ResourceLoader to ingest compose files #592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Humphreys <ge65yay@tum.de>
ndeloof
reviewed
Feb 29, 2024
Collaborator
ndeloof
left a comment
There was a problem hiding this comment.
need to experiment a bit with it, but LGTM in general design
| } | ||
| local, err := loader.Load(ctx, p) | ||
| if err != nil { | ||
| continue |
Contributor
Author
There was a problem hiding this comment.
My thinking was that if Load() failed it would make sense to simply keep trying with another ResourceLoader as it could be caused by an overzealous Accept() implementation, but I realize now that the way it is currently set up if all the Load()s fail there'll be no error thrown until it tries to read an empty compose.
Collaborator
|
Hello @Mjaethers |
Collaborator
|
#701 Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to PR #555 and Issue #554
To achieve consistency in the way resources are loaded for docker compose the config files are now ingested via
ResourceLoader. For local files the existinglocalResourceLoaderis used.To add new ways of loading compose files in the future a new
ResourceLoadershould be implemented and added to the project options.