Merged
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
andynog
reviewed
Apr 25, 2023
Collaborator
andynog
left a comment
There was a problem hiding this comment.
Changes look good to me from a release perspective
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
sergio-mena
approved these changes
Apr 26, 2023
|
|
||
| While the minimum supported version of the Go compiler was bumped to 1.19, no | ||
| 1.19-specific code changes were introduced and this should, therefore, still be | ||
| able to be compiled with earlier versions of Go. It is, however, recommended to |
Collaborator
There was a problem hiding this comment.
Would it make sense to add a sentence here saying that 1.19 is the version used by the core team for all our testing? (CI, e2e, pre-release QA)
Contributor
Author
There was a problem hiding this comment.
Is that not covered in the README by stating the minimum Go version? https://github.com/cometbft/cometbft-db#minimum-go-version
Signed-off-by: Thane Thomson <connect@thanethomson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #54.
📖 CHANGELOG