Skip to content

Release v0.7.1#54

Closed
thanethomson wants to merge 4 commits intomainfrom
release/v0.7.1
Closed

Release v0.7.1#54
thanethomson wants to merge 4 commits intomainfrom
release/v0.7.1

Conversation

@thanethomson
Copy link
Contributor

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson added the release Pull requests that facilitate cutting a release label Apr 13, 2023
@thanethomson thanethomson requested a review from a team as a code owner April 13, 2023 11:36
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Copy link
Contributor Author

By cutting this as v0.7.1, we will effectively be automatically rolling this out to anyone building their software using this version, meaning that the RocksDB update will automatically propagate to users. Should we instead cut this as v0.8.0 and have users deliberately update instead?

cc @yihuang @alexanderbez @robert-zaremba

@robert-zaremba
Copy link

robert-zaremba commented Apr 13, 2023

I think someone already tested the new library (grocksdb) doesn't break the data (it should not).
So doing a patch release makes sense. But let's re-confirm the above.

@yihuang
Copy link

yihuang commented Apr 14, 2023

I think someone already tested the new library (grocksdb) doesn't break the data (it should not). So doing a patch release makes sense. But let's re-confirm the above.

yeah, the only breaking thing is to user's build dependencies, I think should be alright, there's probably not so many user building rocksdb right now I guess.

@thanethomson
Copy link
Contributor Author

I tested this on our side and it breaks the build of our E2E testing image, which to me signals that this should be released in a new breaking release of cometbft-db (i.e. v0.8.0). I'll close this PR and open a follow-up one to release the same changes instead as v0.8.0.

@thanethomson thanethomson deleted the release/v0.7.1 branch April 24, 2023 11:10
@thanethomson thanethomson mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Pull requests that facilitate cutting a release

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants