fix: Use Docker SDK to configure port binding#526
Merged
kodiakhq[bot] merged 4 commits intomainfrom Jul 30, 2025
Merged
Conversation
disq
approved these changes
Jul 30, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
🤖 I have created a release *beep* *boop* --- ## [1.26.18](v1.26.17...v1.26.18) (2025-07-30) ### Bug Fixes * **deps:** Update module github.com/docker/docker to v28.3.3+incompatible [SECURITY] ([#528](#528)) ([bcf436e](bcf436e)) * Use Docker SDK to configure port binding ([#526](#526)) ([63023a1](63023a1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While testing cloudquery/cloudquery#21179 I noticed syncing with docker plugins stopped working (even before cloudquery/cloudquery#21179).
Looks like the host port is not mapped correctly (probably due to changes with recent docker engines), so the CLI can't connect to the plugin gRPC server.
This PR fixes the issue by using the Docker SDK to get the port binding from a string value, ensuring the mapping is done correctly (hopefully for future versions as well)
Use the following steps to ensure your PR is ready to be reviewed
go fmt ./...to format your code 🖊golangci-lint run🚨 (install golangci-lint here)