Merged
Conversation
erezrokah
reviewed
Jul 30, 2025
Member
erezrokah
left a comment
There was a problem hiding this comment.
I think we want to incorporate these changes with https://github.com/cloudquery/plugin-pb-go/pull/525/files.
I'll test this PR with https://github.com/cloudquery/plugin-pb-go/pull/525/files today
1 task
erezrokah
approved these changes
Jul 30, 2025
5 tasks
kodiakhq bot
pushed a commit
to cloudquery/plugin-pb-go
that referenced
this pull request
Jul 30, 2025
#### Summary While testing cloudquery/cloudquery#21179 I noticed syncing with docker plugins stopped working (even before cloudquery/cloudquery#21179). Looks like the host port is not mapped correctly (probably due to changes with recent docker engines), so the CLI can't connect to the plugin gRPC server. This PR fixes the issue by using the Docker SDK to get the port binding from a string value, ensuring the mapping is done correctly (hopefully for future versions as well) ---
39a5dba to
e5dad69
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
🤖 I have created a release *beep* *boop* --- ## [6.26.2](cli-v6.26.1...cli-v6.26.2) (2025-07-30) ### Bug Fixes * **deps:** Update docker ([#21179](#21179)) ([0ff6e79](0ff6e79)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.18 ([#21187](#21187)) ([eb3af75](eb3af75)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21134