fix(miniflare): Create WebSocketPair after fetching target WebSocket#13737
Merged
Conversation
🦋 Changeset detectedLatest commit: 0f5e8d5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
Changeset ReviewFile:
|
| Criterion | Status |
|---|---|
| Version Type | ✅ Patch is appropriate for bug fix |
| Changelog Quality | ✅ Detailed description explaining the race condition, root cause, and fix |
| Markdown Headers | ✅ No h1/h2/h3 headers |
| Analytics | ✅ N/A - no analytics changes |
| Dependabot | ✅ N/A - not a dependency update |
| Experimental Features | ✅ N/A - bug fix for existing feature |
Notes
- Version type: Patch is correct for a bug fix addressing a race condition
- Description quality: Excellent - clearly explains:
- The specific problem (race condition on Windows when Chrome hasn't started accepting connections)
- Root cause (returning endpoint before socket was ready)
- The fix (probing
/json/versionwith retry/backoff) - Additional safety net (retrying transient connection failures)
✅ All changesets look good
Contributor
|
After thorough review of all the substantive changes:
No logic bugs, security issues, backward compatibility violations, or incorrect API behavior found. LGTM |
Contributor
There was a problem hiding this comment.
Devin Review found 1 potential issue.
⚠️ 1 issue in files not directly in the diff
⚠️ AGENTS.md "Requirements" section not updated after Node.js minimum version bump (AGENTS.md:85)
The PR changes the minimum Node.js version from 20 to 22 across all package.json engines fields, the root volta config, bin/wrangler.js, and wrangler-banner.ts, but does not update AGENTS.md which still states Node.js >= 20 under Development Guidelines > Requirements (AGENTS.md:85). A developer or agent following AGENTS.md would attempt to use Node.js 20, only to be rejected by the engines constraint in package.json:57 ("node": ">=22.0.0").
View 5 additional findings in Devin Review.
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
1a88c28 to
fd81c1d
Compare
fd81c1d to
807fc66
Compare
petebacondarwin
approved these changes
May 1, 2026
workers-devprod
approved these changes
May 1, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
Wait for Chrome's DevTools port to actually accept connections before returning from launchBrowser, and retry transient connection failures when the binding worker reaches Chrome. Fixes flaky ConnectEx (#1225) and WSARecv (#64) errors observed when running miniflare browser rendering tests on Windows CI.
…in browser rendering Move WebSocketPair creation and server.accept() to after the fetch call to ensure the target WebSocket is established before creating the proxy pair.
807fc66 to
0f5e8d5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move WebSocketPair creation and server.accept() to after the fetch call to ensure the target WebSocket is established before creating the proxy pair.
Extends and builds upon #13734
A picture of a cute animal (not mandatory, but encouraged)