Skip to content

Fix network tab in DevTools inspector#64

Closed
Electroid wants to merge 1 commit into
mainfrom
fix/devtools-network
Closed

Fix network tab in DevTools inspector#64
Electroid wants to merge 1 commit into
mainfrom
fix/devtools-network

Conversation

@Electroid

Copy link
Copy Markdown
Contributor

Fixes #63

Screen Shot 2021-11-30 at 6 03 18 PM

@Electroid

Copy link
Copy Markdown
Contributor Author

Known issues:

  • Network requests only appear after the 2nd request. This is a runtime issue, which we'll track elsewhere.
  • Dark mode does not work. This is because we have an internal fork of the DevTools UI that is outdated. We need to rebase it, then open source it in this monorepo.

@threepointone

Copy link
Copy Markdown
Contributor

why not use built-pages here? I have modifications that lets it restart on updates/watch mode. does it not work with your changes? You'd also mentioned that the devtools on cloudflareworkers have bugs.

@threepointone threepointone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ questions.

@Electroid

Copy link
Copy Markdown
Contributor Author

The network tab only works with this version— likely because we have some custom extensions to the protocol.

We should figure out how to merge these changes together, I’m sure there are other improvements we could make the the UI.

@threepointone

Copy link
Copy Markdown
Contributor

Please point me to that fork so I can bring those changes in. I can't merge this PR because the refresh-on-change would go away.

@Electroid

Copy link
Copy Markdown
Contributor Author

We're going to defer this until we combine these 2 forks.

@Electroid Electroid closed this Dec 3, 2021
@threepointone threepointone deleted the fix/devtools-network branch December 14, 2021 22:30
petebacondarwin added a commit that referenced this pull request Apr 29, 2026
Wait for Chrome's DevTools port to actually accept connections before
returning from launchBrowser, and retry transient connection failures
when the binding worker reaches Chrome. Fixes flaky ConnectEx (#1225)
and WSARecv (#64) errors observed when running miniflare browser
rendering tests on Windows CI.
petebacondarwin added a commit that referenced this pull request Apr 29, 2026
Wait for Chrome's DevTools port to actually accept connections before
returning from launchBrowser, and retry transient connection failures
when the binding worker reaches Chrome. Fixes flaky ConnectEx (#1225)
and WSARecv (#64) errors observed when running miniflare browser
rendering tests on Windows CI.
petebacondarwin added a commit that referenced this pull request Apr 29, 2026
Wait for Chrome's DevTools port to actually accept connections before
returning from launchBrowser, and retry transient connection failures
when the binding worker reaches Chrome. Fixes flaky ConnectEx (#1225)
and WSARecv (#64) errors observed when running miniflare browser
rendering tests on Windows CI.
petebacondarwin added a commit that referenced this pull request Apr 29, 2026
Wait for Chrome's DevTools port to actually accept connections before
returning from launchBrowser, and retry transient connection failures
when the binding worker reaches Chrome. Fixes flaky ConnectEx (#1225)
and WSARecv (#64) errors observed when running miniflare browser
rendering tests on Windows CI.
petebacondarwin added a commit that referenced this pull request Apr 29, 2026
Wait for Chrome's DevTools port to actually accept connections before
returning from launchBrowser, and retry transient connection failures
when the binding worker reaches Chrome. Fixes flaky ConnectEx (#1225)
and WSARecv (#64) errors observed when running miniflare browser
rendering tests on Windows CI.
petebacondarwin added a commit that referenced this pull request May 1, 2026
Wait for Chrome's DevTools port to actually accept connections before
returning from launchBrowser, and retry transient connection failures
when the binding worker reaches Chrome. Fixes flaky ConnectEx (#1225)
and WSARecv (#64) errors observed when running miniflare browser
rendering tests on Windows CI.
petebacondarwin added a commit that referenced this pull request May 1, 2026
Wait for Chrome's DevTools port to actually accept connections before
returning from launchBrowser, and retry transient connection failures
when the binding worker reaches Chrome. Fixes flaky ConnectEx (#1225)
and WSARecv (#64) errors observed when running miniflare browser
rendering tests on Windows CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

Fix network tab in DevTools

2 participants