🦋 Changeset detected

Latest commit: 82ab129

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Codeowners approval required for this PR:

• ✅ @cloudflare/wrangler

✅ All changesets look good

Let me do a final review of the logic. The code change adds a new branch inside the settingsForOnlyKnownFrameworks.length === 2 block:

if (frameworkIdsFound.has("waku") && frameworkIdsFound.has("hono")) {
    return settingsForOnlyKnownFrameworks.find(
        ({ framework }) => framework.id === "waku"
    );
}

One concern: .find() can return undefined, and the function's return type is DetectedFramework | undefined. If settingsForOnlyKnownFrameworks somehow doesn't contain a waku entry (though it should given the has("waku") check above), this would return undefined, which would cause the caller to treat it as "no framework detected." But this is essentially impossible because frameworkIdsFound is built from settings which is a superset of settingsForOnlyKnownFrameworks, and waku is a known framework ID, so if it's in settings it must also be in settingsForOnlyKnownFrameworks. This is safe.

Actually wait - there's a subtle issue. frameworkIdsFound is built from settings (all frameworks), not settingsForOnlyKnownFrameworks (only known frameworks). If we're inside the settingsForOnlyKnownFrameworks.length === 2 block, there are exactly 2 known frameworks. But the frameworkIdsFound check uses settings which may have more entries. This means frameworkIdsFound.has("waku") && frameworkIdsFound.has("hono") checks whether waku and hono are in settings (which could contain unknown frameworks too). Since waku and hono are both known framework IDs, if they're in settings, they'd also be in settingsForOnlyKnownFrameworks. So if both are present and there are exactly 2 known frameworks, those 2 must be waku and hono. The logic is correct.

This is a clean, well-targeted fix. The changeset is properly formatted. The code follows the existing pattern for framework disambiguation (same approach as the vite handling). No logic bugs, no security issues, no backward compatibility concerns.

LGTM

github run

npm i https://pkg.pr.new/create-cloudflare@13112

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13112

npm i https://pkg.pr.new/miniflare@13112

npm i https://pkg.pr.new/@cloudflare/pages-shared@13112

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13112

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13112

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13112

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13112

npm i https://pkg.pr.new/wrangler@13112

commit: 82ab129