Improve the autoconfig frameworks detection logic#13113
Merged
dario-piotrowicz merged 2 commits intomainfrom Mar 30, 2026
Merged
Improve the autoconfig frameworks detection logic#13113dario-piotrowicz merged 2 commits intomainfrom
dario-piotrowicz merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 47c716a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
✅ All changesets look good |
This comment was marked as outdated.
This comment was marked as outdated.
...er/src/__tests__/autoconfig/details/framework-detection/multiple-frameworks-detected.test.ts
Show resolved
Hide resolved
5 tasks
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
47dd651 to
fd63c89
Compare
petebacondarwin
approved these changes
Mar 30, 2026
Contributor
|
Ugh. This needs a rebase. But I have approved as it stands. |
Member
Author
oof... sorry I didn't notice! 😓 I'm on it! thanks for the approval! 🫶 |
…and add comprehensive unit tests for it
fd63c89 to
47c716a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things (as you can see from its 2 commits):
Extracts autoconfig details framework-detection logic in its own file and adds comprehensive unit tests for it
Simply splits code in
autoconfig/details.tstoindex.tsandframework-detection.ts:This adds a clear separation between different autoconfig detection logic units and also has the effect of making the framework-detection code easily unit-testable. As part of this change then comprehensive unit tests for the latter have been added:
Skip lock file warning for static projects during autoconfig
Currently if users run autoconfig on a fully static project that does not a package manager, they get the following warning:
See:
The warning is valid for non-static projects, however for static projects it might be unnecessary/unhelpful/confusing, so in order to avoid potential user confusion this PR updates autoconfig not to show this warning for static projects.
A picture of a cute animal (not mandatory, but encouraged)