🦋 Changeset detected

Latest commit: 4c39b77

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Codeowners approval required for this PR:

• ✅ @cloudflare/cloudchamber
• ✅ @cloudflare/wrangler

✅ All changesets look good

I've now thoroughly reviewed the entire PR. Let me analyze what I've found:

1. New list.ts - Clean implementation of the containers list command using the Dash API
2. DashApplication model - New type for the summary representation
3. ApplicationsService.listDashApplications - New service method
4. Test coverage - Comprehensive tests for state derivation, error handling, pagination, JSON output
5. instances.ts refactoring - Split non-interactive and --json paths for clarity, renamed ContainerState to InstanceState

The code is well-structured, matches the pattern from the existing instances.ts command, and has good test coverage. The state derivation logic correctly prioritizes: degraded (failed > 0) > provisioning (starting/scheduling > 0) > active (active > 0) > ready (all zero).

Let me check one potential edge case - the err.body.error access in the 400 handler is accessing the error field on the body, which is typed as any on ApiError. The test mock includes error: "bad request" so it matches. This is consistent with the existing instances.ts pattern.

The containers.ts cleanup correctly removes the old listYargs, listCommand, listCommandHandle, listContainersAndChoose, and containersListCommand - all moved to or replaced by list.ts.

The changeset is appropriate - minor for wrangler (new behavior), patch for containers-shared (new type/method).

I don't see any logic bugs, security issues, backward compatibility problems, or incorrect API behavior.

LGTM

github run

npm i https://pkg.pr.new/create-cloudflare@12893

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12893

npm i https://pkg.pr.new/miniflare@12893

npm i https://pkg.pr.new/@cloudflare/pages-shared@12893

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12893

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12893

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12893

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12893

npm i https://pkg.pr.new/wrangler@12893

commit: 4c39b77

Codeowners approval required for this PR:

• ✅ @cloudflare/cloudchamber
• ✅ @cloudflare/wrangler