Skip to content

Add wrangler containers instances command#12873

Merged
gpanders merged 6 commits intomainfrom
ganders/CC-7200
Mar 13, 2026
Merged

Add wrangler containers instances command#12873
gpanders merged 6 commits intomainfrom
ganders/CC-7200

Conversation

@gpanders
Copy link
Copy Markdown
Member

@gpanders gpanders commented Mar 12, 2026 •
edited
Loading

Fixes CC-7200

Add a new wrangler containers instances <application> to interactively list instances associated with an application. This mirrors the instances page in the Cloudflare Dash.

Screenshot:

Screenshot 2026-03-12 at 3 08 03 PM
Open with Devin

gpanders added 2 commits March 12, 2026 13:49
@gpanders
Add options to onKeyPress
b72cacd 
This allows overriding the default escapeCodeTimeout, which is absurdly
high.
@gpanders
Support paginated API requests
f66f18b
@gpanders gpanders requested review from a team as code owners March 12, 2026 20:08
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 12, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: eebd7f2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026 •
edited
Loading

✅ All changesets look good

@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 12, 2026 •
edited
Loading

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@gpanders gpanders changed the title Ganders/cc 7200 Add wrangler containers instances command Mar 12, 2026
ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 12, 2026

I'm Bonk, and I've done a quick review of your PR.

This PR adds wrangler containers instances <application> to interactively list container instances with pagination, DO correlation, and JSON output support.

Issue found:

  1. escapeCodeTimeout: 0 causes arrow keys to be misinterpreted as Esc (packages/wrangler/src/containers/instances.ts:306). With a timeout of 0ms, multi-byte escape sequences (like arrow up \x1b[A) can be split across chunks -- especially over SSH or slow terminals -- causing the first byte to be interpreted as a standalone Esc press, which immediately stops pagination. Suggested fix: use 25 instead of 0.

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 12, 2026 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12873

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12873

miniflare

npm i https://pkg.pr.new/miniflare@12873

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12873

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12873

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12873

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12873

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12873

wrangler

npm i https://pkg.pr.new/wrangler@12873

commit: 274596c

devin-ai-integration[bot]
devin-ai-integration bot reviewed Mar 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

Open in Devin Review

@gpanders gpanders mentioned this pull request Mar 12, 2026
Merged
2 tasks
@gpanders gpanders mentioned this pull request Mar 12, 2026
Merged
2 tasks
emily-shen
emily-shen approved these changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can never figure out if the containers commands are supposed to handle non-DO containers, i thought the containers product as opposed to cloudchamber was that containers used

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 13, 2026
@emily-shen
Copy link
Copy Markdown
Contributor

emily-shen commented Mar 13, 2026

(a rebase should fix your windows CI error)

@gpanders
Copy link
Copy Markdown
Member Author

gpanders commented Mar 13, 2026

I think we should also update wrangler containers list to use the Dash endpoint as well (which supports pagination) and have it use a similar UI as wrangler containers instances. Will do that in a follow up

IRCody
IRCody reviewed Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@IRCody IRCody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've lost the ability to click approve 😅 but LGTM.

@gpanders gpanders merged commit 2b9a186 into main Mar 13, 2026
37 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 13, 2026
@gpanders gpanders deleted the ganders/CC-7200 branch March 13, 2026 17:23
@workers-devprod workers-devprod mentioned this pull request Mar 13, 2026
Merged
@gpanders gpanders mentioned this pull request Mar 13, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@ask-bonk ask-bonk[bot] ask-bonk[bot] left review comments

@nikitassharma nikitassharma nikitassharma approved these changes

@emily-shen emily-shen emily-shen approved these changes

+1 more reviewer

@IRCody IRCody IRCody left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gpanders @workers-devprod @emily-shen @IRCody @nikitassharma