Skip to content

fix promises export for readline & inspector#5740

Merged
anonrig merged 1 commit intomainfrom
yagiz/fix-promises-nodejs
Dec 22, 2025
Merged

fix promises export for readline & inspector#5740
anonrig merged 1 commit intomainfrom
yagiz/fix-promises-nodejs

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Dec 22, 2025

This is required to get rid of node:inspector and node:readline polyfills on workers-sdk

@anonrig anonrig requested review from a team as code owners December 22, 2025 15:16
@anonrig anonrig enabled auto-merge (rebase) December 22, 2025 15:16
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 22, 2025

CodSpeed Performance Report

Merging #5740 will improve performance by 13.12%

Comparing yagiz/fix-promises-nodejs (da1bd47) with main (0b84f58)

Summary

⚡ 1 improvement
✅ 56 untouched
⏩ 34 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
Encode_ASCII_32[TextEncoder][0/0/32] 3.4 ms 3 ms +13.12%

Footnotes

  1. 34 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@anonrig anonrig merged commit 0688c51 into main Dec 22, 2025
21 of 22 checks passed
@anonrig anonrig deleted the yagiz/fix-promises-nodejs branch December 22, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants