fix promises export for readline & inspector

anonrig · anonrig · commit da1bd474b28e · 2025-12-22T10:15:30.000-05:00
diff --git a/src/node/BUILD.bazel b/src/node/BUILD.bazel
@@ -14,10 +14,12 @@ wd_ts_bundle(
         "assert/*.ts",
         "dns/*.ts",
         "fs/*.ts",
-        "stream/*.js",
+        "inspector/*.ts",
         "path/*.ts",
-        "util/*.ts",
+        "readline/*.ts",
+        "stream/*.js",
         "timers/*.ts",
+        "util/*.ts",
     ]),
     schema_id = "0xbcc8f57c63814005",
     tsconfig_json = "tsconfig.json",
diff --git a/src/node/inspector/promises.ts b/src/node/inspector/promises.ts
@@ -52,6 +52,22 @@ export const Network: typeof _Network = {
   loadingFailed(_params: _Network.LoadingFailedEventDataType): void {
     throw new ERR_METHOD_NOT_IMPLEMENTED('Network.loadingFailed');
   },
+  webSocketHandshakeResponseReceived(
+    _params: _Network.WebSocketHandshakeResponseReceivedEventDataType
+  ): void {
+    throw new ERR_METHOD_NOT_IMPLEMENTED(
+      'Network.webSocketHandshakeResponseReceived'
+    );
+  },
+  webSocketClosed(_params: _Network.WebSocketClosedEventDataType): void {
+    throw new ERR_METHOD_NOT_IMPLEMENTED('Network.webSocketClosed');
+  },
+  webSocketCreated(_params: _Network.WebSocketCreatedEventDataType): void {
+    throw new ERR_METHOD_NOT_IMPLEMENTED('Network.webSocketCreated');
+  },
+  dataSent(_params: unknown): void {
+    throw new ERR_METHOD_NOT_IMPLEMENTED('Network.dataSent');
+  },
 };
 
 export class Session extends EventEmitter implements _Session {
diff --git a/src/workerd/api/node/tests/inspector-nodejs-test.js b/src/workerd/api/node/tests/inspector-nodejs-test.js
@@ -1,6 +1,7 @@
 import inspector from 'node:inspector';
 import assert from 'node:assert';
 import { EventEmitter } from 'node:events';
+import promises from 'node:inspector/promises';
 
 export const inspectorClose = {
   test() {
@@ -289,3 +290,10 @@ export const inspectorSessionInheritance = {
     }
   },
 };
+
+export const inspectorPromises = {
+  test() {
+    assert.strictEqual(typeof promises, 'object');
+    assert.strictEqual(typeof promises.Session, 'function');
+  },
+};
diff --git a/src/workerd/api/node/tests/readline-nodejs-test.js b/src/workerd/api/node/tests/readline-nodejs-test.js
@@ -1,6 +1,7 @@
 import readline from 'node:readline';
 import assert from 'node:assert';
 import { EventEmitter } from 'node:events';
+import promises from 'node:readline/promises';
 
 export const readlineClearLine = {
   test() {
@@ -207,3 +208,10 @@ export const readlineFunctionReturnValues = {
     }
   },
 };
+
+export const readlineImportedPromisesModule = {
+  test() {
+    assert.strictEqual(typeof promises, 'object');
+    assert.strictEqual(typeof promises.createInterface, 'function');
+  },
+};
