[R2 instrumentation] Add tags for requests#5006
Merged
jmorrell-cloudflare merged 6 commits intomainfrom Sep 15, 2025
Merged
Conversation
220cc82 to
5939d80
Compare
mar-cf
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows on from the work in #4983
Focuses on annotating the request arguments for R2. There are likely more of them then you'd think.
get and put
cloudflare.r2.request.only_if.etag_matchescloudflare.r2.request.only_if.etag_does_not_matchcloudflare.r2.request.only_if.uploaded_beforecloudflare.r2.request.only_if.uploaded_afterget
You can either pass in specific range arguments, or a header: https://workers-types.pages.dev/#R2GetOptions
cloudflare.r2.request.range.offsetcloudflare.r2.request.range.lengthcloudflare.r2.request.range.suffixcloudflare.r2.request.rangecloudflare.r2.request.ssec_keyput and createMultipartUpload
cloudflare.r2.request.custom_metadatacloudflare.r2.request.http_metadata.content_typecloudflare.r2.request.http_metadata.content_encodingcloudflare.r2.request.http_metadata.content_dispositioncloudflare.r2.request.http_metadata.content_languagecloudflare.r2.request.http_metadata.cache_controlcloudflare.r2.request.http_metadata.cache_expirycloudflare.r2.request.storage_classcloudflare.r2.request.ssec_keyput
cloudflare.r2.request.sizecloudflare.r2.request.checksum.typecloudflare.r2.request.checksum.valuedelete
cloudflare.r2.request.keyslist
cloudflare.r2.request.limitcloudflare.r2.request.prefixcloudflare.r2.request.cursorcloudflare.r2.request.delimitercloudflare.r2.request.start_aftercloudflare.r2.request.include.http_metadatacloudflare.r2.request.include.custom_metadataFurther changes
cursorinstead of just a boolean whether one was present or not