Skip to content

[R2 instrumentation] Add tags for responses#4983

Merged
jmorrell-cloudflare merged 3 commits intomainfrom
jmorrell/r2-add-attributes-2
Sep 8, 2025
Merged

[R2 instrumentation] Add tags for responses#4983
jmorrell-cloudflare merged 3 commits intomainfrom
jmorrell/r2-add-attributes-2

Conversation

@jmorrell-cloudflare
Copy link
Copy Markdown
Contributor

@jmorrell-cloudflare jmorrell-cloudflare commented Sep 3, 2025

  • Adds helper for getting success and error tags based on R2Result and adds it to every method
  • Factors out the common logic for head, get, and put
  • Adds response tags for all of the R2 methods, detailed below

For all R2 methods:

  • error.type
  • cloudflare.r2.response.success
  • cloudflare.r2.error.message
  • cloudflare.r2.error.code

For head, get, and put:

  • cloudflare.r2.response.etag
  • cloudflare.r2.response.size
  • cloudflare.r2.response.uploaded
  • cloudflare.r2.response.checksum.value
  • cloudflare.r2.response.checksum.type
  • cloudflare.r2.response.storage_class
  • cloudflare.r2.response.ssec_key
  • cloudflare.r2.response.content_type
  • cloudflare.r2.response.content_encoding
  • cloudflare.r2.response.content_disposition
  • cloudflare.r2.response.content_language
  • cloudflare.r2.response.cache_control
  • cloudflare.r2.response.cache_expiry
  • cloudflare.r2.response.custom_metadata

For createMultipartUpload:

  • cloudflare.r2.response.upload_id

For list:

  • cloudflare.r2.response.returned_objects
  • cloudflare.r2.response.delimited_prefixes
  • cloudflare.r2.response.truncated
  • cloudflare.r2.response.cursor

delete, resumeMultipartUpload, uploadPart, complete do not have additional response tags

@danlapid danlapid force-pushed the jmorrell/r2-add-attributes-2 branch 2 times, most recently from 37e9ac7 to eec63fd Compare September 4, 2025 11:13
Base automatically changed from jmorrell/r2-add-attributes-1 to main September 4, 2025 16:11
@jmorrell-cloudflare jmorrell-cloudflare force-pushed the jmorrell/r2-add-attributes-2 branch from eec63fd to 0c3a95a Compare September 4, 2025 19:45
@jmorrell-cloudflare jmorrell-cloudflare marked this pull request as ready for review September 4, 2025 23:17
@jmorrell-cloudflare jmorrell-cloudflare requested review from a team as code owners September 4, 2025 23:17
@jmorrell-cloudflare jmorrell-cloudflare changed the title [R2 instrumentation] Add tags for head, get, put responses [R2 instrumentation] Add tags for responses Sep 5, 2025
@jmorrell-cloudflare jmorrell-cloudflare merged commit 6d9b2be into main Sep 8, 2025
21 checks passed
@jmorrell-cloudflare jmorrell-cloudflare deleted the jmorrell/r2-add-attributes-2 branch September 8, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants