Skip to content

[nfc] always run ci jobs#4317

Merged
anonrig merged 1 commit intomainfrom
maizatskyi/2025-06-12-trigger-ci
Jun 12, 2025
Merged

[nfc] always run ci jobs#4317
anonrig merged 1 commit intomainfrom
maizatskyi/2025-06-12-trigger-ci

Conversation

@mikea
Copy link
Contributor

@mikea mikea commented Jun 12, 2025

These jobs are required and if we don't run them we can't land docs-only changes.

Undos #3552

These jobs are required and if we don't run them we can't land
docs-only changes.
@mikea mikea requested a review from anonrig June 12, 2025 15:19
@mikea mikea requested review from a team as code owners June 12, 2025 15:19
@npaun
Copy link
Member

npaun commented Jun 12, 2025

Not a blocker but we can put an if: statement on individual steps to avoid running them if code wasn't changed.

@anonrig anonrig merged commit cced420 into main Jun 12, 2025
20 checks passed
@anonrig anonrig deleted the maizatskyi/2025-06-12-trigger-ci branch June 12, 2025 15:45
@fhanau
Copy link
Contributor

fhanau commented Jun 12, 2025

Thanks for landing this, I suggested the initial change but it clearly didn't work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants