Merged
Conversation
fhanau
reviewed
Feb 14, 2025
941ce95 to
888ffa1
Compare
fhanau
approved these changes
Feb 18, 2025
Contributor
fhanau
left a comment
There was a problem hiding this comment.
Changes LGTM. Also noticed today that doc/** needs to be docs/** instead, maybe we can fit that in here.
Member
Author
|
It was on auto-merge. We can fix it on a new PR |
yj7o5
pushed a commit
to yj7o5/workerd
that referenced
this pull request
Feb 25, 2025
* do not trigger ci if you don't need it * do not run internal build on .github change
Contributor
|
This makes it impossible to submit doc-only change, which imo defeats the purpose of this change to land such PRs faster? I suggest reverting this, since this is not the first time we hit it. I don't think protected branch configuration is flexible enough to conditionally require builds, is it @danlapid ? |
gabivlj
pushed a commit
to gabivlj/workerd
that referenced
this pull request
Jun 18, 2025
* do not trigger ci if you don't need it * do not run internal build on .github change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let's limit our scope for triggering ci