Conversation
ServiceDesignators are meant to be resolved at link time, so that errors can be reported before the service starts up.
jasnell
approved these changes
Nov 29, 2024
Member
Author
Using a simple array seems strictly easier to understand than a union with zero/one/many variants. REVIEW: Can we simply remove `logging`? It was introduced relatively recently. Is anyone depending on it yet?
86adb53 to
9c48d92
Compare
Collaborator
|
Nope, intentionally hadn't documented it just yet but better to ask the wrangler folks. Not sure if anyone on that side has made use of it. |
Member
Author
|
I don't see |
`logging` was introduced recently and hasn't been documented nor advertised yet, so likely isn't used. Since it's still the last field in the capnp, we can probably get away with removing it and replacing it with `tails`.
danlapid
approved these changes
Nov 29, 2024
For consistency with the config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some issues from #3021, which I noticed while working on something unrelated.
The third commit is more of a suggestion. Do we think anyone is using
loggingyet? If so, maybe I should drop this commit. If not, maybe I should change the commit to actually removeloggingin favor of the simpler flat array which I've namedtails... let me know.