Implement original tail worker support for local dev#3021
Merged
Conversation
7188e44 to
8046c83
Compare
danlapid
reviewed
Oct 29, 2024
danlapid
reviewed
Oct 29, 2024
8046c83 to
828f9c6
Compare
Collaborator
Author
|
Odd / non-obvious crashes in this PR on windows :-/ ... not getting any useful traces out of the CI run and unable to reproduce locally so I'll have to do a bit of trial-and-error debugging via fixup commits. |
danlapid
reviewed
Oct 29, 2024
danlapid
reviewed
Oct 29, 2024
0ab6cc9 to
c5433df
Compare
c5433df to
33a9135
Compare
danlapid
approved these changes
Oct 30, 2024
Collaborator
danlapid
left a comment
There was a problem hiding this comment.
LGTM, was the se translator useful? Do we want to add it in a separate PR?
Collaborator
Author
Not really. Enabling the flag necessary seemed to make the build hang forever. I managed to spot the issue while I was waiting for it to finish building lol |
Member
|
Are there any tests for this? |
kentonv
reviewed
Nov 29, 2024
| moduleFallback @13 :Text; | ||
|
|
||
| # Tail worker configuration | ||
| logging :union { |
Member
There was a problem hiding this comment.
This could have just been:
tails @14 :List(ServiceDesignator);
The union adds unnecessarily complexity.
Is anyone using this yet? Can we change it?
Please remember to tag me on changes to capnp APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables tail workers for local development in workerd