use Exception.clone instead of copy constructor#6493
Conversation
|
This is correct — I've now reviewed the entire diff thoroughly. This is a mechanical change across 42 files:
All transformations are correct and consistent. The dependency bump, the LGTM |
jasnell
left a comment
There was a problem hiding this comment.
Oh that's going to be some difficult muscle memory to retrain... but makes sense.
Merging this PR will improve performance by 40.18%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | simpleStringBody[Response] |
27.2 µs | 19.4 µs | +40.18% |
Comparing maizatskyi/2026-04-03-exception-clone (fe2f924) with main (22c1ca0)2
Footnotes
-
129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(fe2f924) during the generation of this report, so 22c1ca0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
e00eedf to
8bd3e28
Compare
|
The generated output of |
8bd3e28 to
6578d64
Compare
6578d64 to
fe2f924
Compare
Downstream of capnproto/capnproto#2615