add Exception::clone() and remove exception copy constructor#2615
Merged
Conversation
e8a8dc0 to
82efa5f
Compare
mikea
added a commit
to cloudflare/workerd
that referenced
this pull request
Apr 3, 2026
This was referenced Apr 3, 2026
kentonv
reviewed
Apr 5, 2026
kentonv
left a comment
Member
There was a problem hiding this comment.
Seems like it'd be easier to manage downstream changes if we added clone() first, then updated everyone, then removed the copy constructor, in separate PRs? But up to you.
82efa5f to
4364fd0
Compare
4364fd0 to
eeeb367
Compare
kentonv
approved these changes
Apr 15, 2026
eeeb367 to
42c5dfc
Compare
mikea
added a commit
to cloudflare/workerd
that referenced
this pull request
Apr 16, 2026
mikea
added a commit
to cloudflare/workerd
that referenced
this pull request
Apr 16, 2026
mikea
added a commit
to cloudflare/workerd
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as discussed in #2613
it will take me a bit to align downstream changes.